skills: SESSION_BUSY is two CLI invocations, not an in-page lock - #389
Open
ankitranjan7 wants to merge 1 commit into
Open
skills: SESSION_BUSY is two CLI invocations, not an in-page lock#389ankitranjan7 wants to merge 1 commit into
ankitranjan7 wants to merge 1 commit into
Conversation
Show overlapping webcmd --session commands as the way to contend for a Session. Wait and retry; do not lock inside page.evaluate. Closes #385
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #385. Skill half of #378.
SESSION_BUSYis produced by a secondwebcmd --session <id> …while the first still holds the Session. It is not a homemade flag insidepage.evaluate.Guidance:
SESSION_BUSY, wait for the listed holder, then retry the same command.--forceclose only when that holder is dead.Runtime lock implementation stays in #378. Published skill names no eval fixture.
Type of Change
Checklist
skill-src/, I ranmake buildand committedskills/