fix(cli): never prompt in webcmd setup when stdin is not a TTY - #369
Merged
Conversation
Non-interactive setup now requires --mode, and hosted mode also requires --api-key. Detached stdin exits 2 instead of printing a prompt and hanging.
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webcmd setupwith stdin detached printedUse hosted Webcmd Cloud or local Webcmd?and then crashed with exit 13 (unsettled top-level await). Agents cannot answer a prompt.After
TTY without flags still prompts. Flags skip prompts on a TTY too. Readline is not created unless a prompt is actually needed.
Hosted impact
Verification
npx tsc --noEmit— cleannpx vitest run --project unit src/hosted/setup.test.ts— 10 passed, including a stdin-detached hang test (8s bound)