fix(cli): reject unknown profile use instead of poisoning the default - #367
Merged
Conversation
profile use now checks membership against the same set as profile list and exits 2 with the valid aliases and contextIds enumerated.
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webcmd profile use __audit_nope__wrote that string as the default Cloak profile and exited 0. Later browser commands then ran against a profile that does not exist.After
Membership is the same set
profile listshows: connected daemon profiles, saved aliases, and the current default. A saved alias still works when the daemon is down. Unknown names no longer persist.Hosted impact
Verification
npx tsc --noEmit— cleannpx vitest run --project unit src/browser/profile.test.ts src/cli.test.ts— 146 passed