Skip to content

fix(install): honor CARGO_HOME/RUSTUP_HOME + document env-overridable install paths - #3

Open
agentik-os wants to merge 1 commit into
mainfrom
chore/clean-home-env-paths
Open

fix(install): honor CARGO_HOME/RUSTUP_HOME + document env-overridable install paths#3
agentik-os wants to merge 1 commit into
mainfrom
chore/clean-home-env-paths

Conversation

@agentik-os

@agentik-os agentik-os commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Quoi

install.sh hardcodait source "$HOME/.cargo/env", ce qui ignore un CARGO_HOME défini par l'hôte et force la toolchain Rust dans ~/.cargo. Ce PR :

  • honore CARGO_HOME (et RUSTUP_HOME, déjà respecté par rustup) ;
  • documente que OMEGA_DIR / INSTALL_DIR / OMEGA_SRC / CARGO_HOME / RUSTUP_HOME sont overridables par env, pour qu'un hôte route ses chemins d'install (setups XDG / home propre, installs multi-users partagées) sans forker le script.

Pourquoi

Permet un rangement propre côté hôte (ex. serveur multi-user où les caches/toolchains vont hors $HOME) sans toucher au script. Aucun chemin spécifique à un hôte n'est hardcodé : OmegaOS reste générique.

Parité d'install (L0)

Comportement identique quand les vars ne sont pas définies (défauts inchangés) → un git clone && ./install.sh standard se comporte exactement pareil. bash -n OK.

🤖 Generated with Claude Code

… paths

install.sh hardcoded `source "$HOME/.cargo/env"`, ignoring a host-set
CARGO_HOME and forcing the Rust toolchain into ~/.cargo. Make it honor the
standard CARGO_HOME (RUSTUP_HOME is already honored by rustup), and document
that OMEGA_DIR / INSTALL_DIR / OMEGA_SRC / CARGO_HOME / RUSTUP_HOME are all
env-overridable so a host can route install paths (XDG / clean-home setups,
shared multi-user installs) without forking the script.

Behavior is identical when the vars are unset (defaults unchanged), so install
parity (L0) is preserved.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 08325c41-4329-4d12-a8e9-c8ad8d2cffc5

📥 Commits

Reviewing files that changed from the base of the PR and between c09b845 and d4fd8d8.

📒 Files selected for processing (1)
  • install.sh

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Installer now supports customizable installation paths via environment variables, providing greater flexibility for deployments across different system configurations.
    • Improved Rust toolchain setup that properly respects custom CARGO_HOME environment variable overrides, ensuring consistent initialization behavior.

Walkthrough

The installer script is updated to document that installation paths are configurable via environment variables (OMEGA_DIR, INSTALL_DIR, OMEGA_SRC, and standard Rust toolchain variables), and Cargo environment sourcing now respects the CARGO_HOME override rather than always using the hardcoded default.

Environment variable configuration

Layer / File(s) Summary
Install path documentation and Cargo environment sourcing
install.sh
Documentation comments clarify environment variable overrides for install directories and Rust toolchain paths. Cargo environment sourcing respects CARGO_HOME configuration, defaulting to $HOME/.cargo when unset.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 A rabbit configures its hutch with care,
Environment paths defined, declared with flair,
No hardcoded homes, just fallbacks so fair,
Each tool finds its place in the mountain air! 🏔️


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant