fix(install): honor CARGO_HOME/RUSTUP_HOME + document env-overridable install paths - #3
fix(install): honor CARGO_HOME/RUSTUP_HOME + document env-overridable install paths#3agentik-os wants to merge 1 commit into
Conversation
… paths install.sh hardcoded `source "$HOME/.cargo/env"`, ignoring a host-set CARGO_HOME and forcing the Rust toolchain into ~/.cargo. Make it honor the standard CARGO_HOME (RUSTUP_HOME is already honored by rustup), and document that OMEGA_DIR / INSTALL_DIR / OMEGA_SRC / CARGO_HOME / RUSTUP_HOME are all env-overridable so a host can route install paths (XDG / clean-home setups, shared multi-user installs) without forking the script. Behavior is identical when the vars are unset (defaults unchanged), so install parity (L0) is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe installer script is updated to document that installation paths are configurable via environment variables (OMEGA_DIR, INSTALL_DIR, OMEGA_SRC, and standard Rust toolchain variables), and Cargo environment sourcing now respects the CARGO_HOME override rather than always using the hardcoded default. Environment variable configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Quoi
install.shhardcodaitsource "$HOME/.cargo/env", ce qui ignore unCARGO_HOMEdéfini par l'hôte et force la toolchain Rust dans~/.cargo. Ce PR :CARGO_HOME(etRUSTUP_HOME, déjà respecté par rustup) ;OMEGA_DIR/INSTALL_DIR/OMEGA_SRC/CARGO_HOME/RUSTUP_HOMEsont overridables par env, pour qu'un hôte route ses chemins d'install (setups XDG / home propre, installs multi-users partagées) sans forker le script.Pourquoi
Permet un rangement propre côté hôte (ex. serveur multi-user où les caches/toolchains vont hors
$HOME) sans toucher au script. Aucun chemin spécifique à un hôte n'est hardcodé : OmegaOS reste générique.Parité d'install (L0)
Comportement identique quand les vars ne sont pas définies (défauts inchangés) → un
git clone && ./install.shstandard se comporte exactement pareil.bash -nOK.🤖 Generated with Claude Code