fix: supersede client delivery assurance chain - #2
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
agentik-os
left a comment
There was a problem hiding this comment.
Operator independent review: BLOCKED
Exact head reviewed: 0d72f726af61222d2a09a6a306e46526ddcac004.
Blocking findings
-
Viewport enforcement trusts mutable metadata (
scripts/client_control.py:2649-2705). The code verifies screenshot digest, but compares required dimensions only to storedwidth/height; it never compares decoded image dimensions fromclient_evidence_artifact()to those claims. Independent runtime probe accepted four required viewport records backed by the same actual 1x1 PNG. -
Browser principal/probe is not bound to the browser execution (
scripts/client_control.py:2577-2638,2778-2822).verify_browser_session()proves only session/time/URL browser tool activity. Principal and probe come from the report and static runtime profile, not from the recorded browser tool execution, so equality to config is not proof of the executing authenticated principal. -
Linear attachment metadata is not revalidated on readback (
scripts/client_control.py:1378+).update_evidence()validates new CLI input, but a persisted work record containing an empty title, overlong subtitle, andjavascript:URL was accepted bylinear_sync_plan(). Material gates must validate persisted metadata at use/readback, not only at ingestion. -
Integration boundary: GitHub reports this PR
CONFLICTING / DIRTYagainstmain, which already contains the previously merged divergentcf2fce9line. Rebasing or merging would violate the requested exact chain, so Operator did not alter history.
Green evidence that does not override blockers
./scripts/test.sh: Rust 86 + 26 PASS; Python 139 PASS; web 15 PASS; typecheck/build PASS; npm audit 0 vulnerabilities.- Focused delivery/security suite: 8 PASS.
- Isolated CLI canary: four configured viewports present; production hard block PASS; no run artifact created.
- Exact branch SHA readback PASS; no client credentials used.
Verdict: BLOCKED. Keep draft. Do not merge or deploy this exact chain until the three logic defects are fixed in a new reviewed commit and the divergent-main integration strategy is explicitly resolved.
Scope
Supersedes the previously merged delivery-assurance line with the exact reviewed chain:
e2fb9b99fde03f12e766ede8d3136ae418848196b2c822db6d3b009fee33e2e5fe3b20567c6601f60d72f726af61222d2a09a6a306e46526ddcac004Verification
139 passed in 7.60s8 passed, 37 deselectedgit diff --checkand Python compile checks passSafety
The previous remote branch tip
cf2fce991dab04920c5c224205fd5a89c8864d73is preserved atbackup/feat-client-delivery-assurance-cf2fce9-20260827.Draft remains pending final independent review and CI.