Conversation
added 2 commits
December 4, 2025 22:57
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Agent Client Protocol (ACP) schema from version 0.8.0 to 0.9.1. The changes are primarily mechanical updates to auto-generated Python code based on the updated JSON schema, with the main enhancement being more precise type definitions and expanded documentation for the _meta extensibility property across all model classes.
Key Changes:
- Updated schema version reference from
v0.8.0tov0.9.1across all files - Enhanced
_metafield type fromOptional[Any]toOptional[Dict[str, Any]]with comprehensive documentation explaining ACP's extensibility mechanism - Added
Dictto Python type imports to support the more specific type annotation - Removed discriminator-based union handling for MCP server types (schema simplification)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/acp/schema.py |
Auto-generated Python models updated with precise _meta typing (Dict[str, Any]), expanded documentation, and removal of discriminator field from McpServerStdio |
src/acp/meta.py |
Schema version reference updated to v0.9.1 |
schema/schema.json |
JSON schema source updated with detailed _meta property specifications including additionalProperties: true and comprehensive descriptions for all model definitions |
schema/VERSION |
Version reference file updated to refs/tags/v0.9.1 |
examples/echo_agent.py |
Import statements alphabetically reordered (McpServerStdio moved to correct alphabetical position) |
examples/agent.py |
Import statements alphabetically reordered (McpServerStdio moved to correct alphabetical position) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
PsiACE
added a commit
that referenced
this pull request
Dec 4, 2025
* chore: make check happy Signed-off-by: Chojan Shang <chojan.shang@vesoft.com> * chore: gen schema with 0.9.1 Signed-off-by: Chojan Shang <chojan.shang@vesoft.com> * chore: bump to 0.7.0 Signed-off-by: Chojan Shang <chojan.shang@vesoft.com> --------- Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as title
Related issues
Testing
Docs & screenshots
Checklist
feat:,fix:).make gen-all) are called out if applicable.