feat: Auto-generate agent/client methods based on the schema#36
Merged
PsiACE merged 2 commits intoagentclientprotocol:0.7.xfrom Nov 20, 2025
Merged
feat: Auto-generate agent/client methods based on the schema#36PsiACE merged 2 commits intoagentclientprotocol:0.7.xfrom
PsiACE merged 2 commits intoagentclientprotocol:0.7.xfrom
Conversation
Signed-off-by: Frost Ming <me@frostming.com>
1 task
PsiACE
reviewed
Nov 20, 2025
Member
PsiACE
left a comment
PsiACE
left a comment
There was a problem hiding this comment.
We still depend on the post-generation overrides in scripts/gen_schema.py: without them, datamodel-code-generator produces plain str fields (e.g. PromptResponse.stop_reason) and dict defaults (e.g. AgentCapabilities.mcp_capabilities). The current warnings (“failed to override default…”) happen because --snake-case-field renamed the generated attributes (stop_reason, mcp_capabilities, etc.), while the override lists still use camelCase. Before we carry these fixes forward, could you confirm whether you still expect these override steps to remain, or if you have a better approach in mind?
Signed-off-by: Frost Ming <me@frostming.com>
Contributor
Author
|
Thanks, overrides config is fixed |
4 tasks
PsiACE
pushed a commit
that referenced
this pull request
Dec 4, 2025
* feat: Auto-generate agent/client methods based on the schema Signed-off-by: Frost Ming <me@frostming.com> * fix: overrides in gen_schema.py Signed-off-by: Frost Ming <me@frostming.com> --------- Signed-off-by: Frost Ming <me@frostming.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Testing
Docs & screenshots
Checklist
feat:,fix:).make gen-all) are called out if applicable.