feat: change field names to snake case#31
Merged
PsiACE merged 2 commits intoagentclientprotocol:0.7.xfrom Nov 19, 2025
Merged
Conversation
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
PsiACE
approved these changes
Nov 19, 2025
Member
PsiACE
left a comment
There was a problem hiding this comment.
LGTM 💯
It's great to have a true Python expert helping us with this.
Just a heads-up: I've prepared a branch named 0.7.x as the target branch. I plan to introduce these significant pythonic changes in the next protocol version release.
1 task
PsiACE
pushed a commit
that referenced
this pull request
Dec 4, 2025
* feat: change field names to snake case Signed-off-by: Frost Ming <me@frostming.com> * fix lint errors Signed-off-by: Frost Ming <me@frostming.com> --------- Signed-off-by: Frost Ming <me@frostming.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the field names for models to be snake case
Constructing the models should be backward-compatible, but accessing is not:
So this should be considered a breaking change, should better open a dedicated branch and merge to it.
Checklist
feat:,fix:).make gen-all) are called out if applicable.