chore(release): 0.2.2 - store-check polish#70
Merged
Conversation
Clears the safe Obsidian store-check findings: - js-yaml ^4.1.0 -> ^4.2.0: patches GHSA-h67p-54hq-rp68 (moderate quadratic-complexity DoS in YAML merge-key alias handling); npm audit now clean. Stays on 4.x; merge engine tests green. - README: reword the Manual-install path to drop the <your-vault> token the checker flags as placeholder text. - release.yml: attest build provenance for main.js/styles.css/manifest.json (id-token + attestations perms) so release assets are verifiable. Deferred (minAppVersion 1.11.4 gated): setWarning->setDestructive, display->getSettingDefinitions. Kept js-yaml over Obsidian parseYaml to preserve the pure/unit-testable merge engine.
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the safe findings from the pre-submission Obsidian plugin checker. None were blockers (all Warning/Recommendation), but two are worth removing before review sees them.
Fixed
^4.1.0->^4.2.0- patches GHSA-h67p-54hq-rp68 (moderate: quadratic-complexity DoS via repeated aliases in YAML merge keys; affected<=4.1.1).npm auditis now clean. Stays within 4.x (5.0.0 is a major), merge-engine tests green.<your-vault>token the checker flags as "placeholder text".main.js/styles.css/manifest.json(addsid-token: write+attestations: write), so published assets are cryptographically verifiable.Deliberately NOT changed
setWarning -> setDestructiveanddisplay -> getSettingDefinitions: both new APIs are ~1.13.0;minAppVersionis 1.11.4, so adopting them would crash on 1.11-1.12. Deferred until a minAppVersion bump. Old APIs still work (not removed).parseYamlso the 3-way merge engine stays pure / no-obsidian-import / unit-testable.builtin-modules(devDependency, esbuild externals): not shipped; the dynamic list is more correct than a hardcoded one, andcheck-bundle.mjsalready guards the bundle.isDesktop-guarded~/.agentage/auth.json(0600) +vaults.jsonmirror shared with the agentage CLI; disclosed in README.Verify
npm run verifygreen locally (68 tests, type-check + lint + format + build + check:hosts/docs/bundle). Release0.2.2(manifest + versions.json bumped).