feat: defer mobile (isDesktopOnly: true) + honest docs; release 0.1.6#64
Merged
Conversation
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the plugin honestly desktop-only instead of claiming mobile support that doesn't complete.
Why: mobile sign-in doesn't round-trip inside Obsidian's Capacitor WebView —
window.open(_blank)opens an in-app browser (no shared auth session) and theobsidian://deep-link callback doesn't reliably return, so users get stuck signed-out and every action is gated off. The git/VaultFs layer itself is mobile-safe; sign-in + first-sync.gitdetection are the unverified parts.Change
manifest.json:isDesktopOnly: false → true— Obsidian now hides/disables it on phones (no broken install), instead of offering a plugin that can't sign in.README: status banner + Features + Getting started reworded to desktop-only; "Mobile support (experimental)" → "Mobile (planned)" (groundwork in place, pending device-verified sign-in + sync).CLAUDE.md+ amain.tscomment: corrected the stale "VaultFs built, not yet wired / desktop uses node fs" claims (VaultFs is the git fs on every platform; node fs is only the desktop~/.agentagemirror).Release: bumps 0.1.5 → 0.1.6.
npm run verifygreen (66 tests, build, host/docs/bundle checks).Re-enablement playbook (sign-in fix + mobile smoke) tracked in the submission/feature doc.