FEATURE: Allow umask to be changed via docker environment UMASK setting#1684
Open
louisjg wants to merge 1 commit into
Open
FEATURE: Allow umask to be changed via docker environment UMASK setting#1684louisjg wants to merge 1 commit into
louisjg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows a user to specify a umask setting using a docker UMASK environment var.
The reason for this is because agent zero runs as root. When it writes files to the workspace, it writes them as root:root and the user outside the container cannot modify them.
One solution to this is to add the user to an "agentzero" group and use the setgid bit so whatever is written under /a0/usr belongs to a group the user has access to. However, since agent-zero uses a default umask of 022 the user still cannot write to these files.
By allowing the user to specify a umask of 002, the agent now writes files to /a0/usr that belong to the group via setgid and are writeable by the group via the umask.