Repository navigation
test: Fix macos unit test failures - #2429
Merged
Eitan Yarmush (EItanya) merged 3 commits intoOct 10, 2026
Merged
Eitan Yarmush (EItanya) merged 3 commits into
Eitan Yarmush (EItanya) merged 3 commits into
Conversation
Keep the portable DNS relay implementation available to unit tests on every supported development platform. Previously, relay.go referenced Linux-only network namespace APIs, so the DNS package did not compile when make test ran on macOS. Now the namespace-serving method lives in a Linux-tagged file while relay construction and socket-level tests remain portable. Signed-off-by: timflannagan <timflannagan@gmail.com>
Prevent developer AWS profile settings from changing object storage unit test behavior. Previously, TestNewFromEnv redirected AWS config files but still inherited AWS_PROFILE and AWS_DEFAULT_PROFILE. An exported profile could make the AWS SDK reject the intentionally missing test configuration. Now the test clears both profile selectors before constructing the S3 client. Signed-off-by: timflannagan <timflannagan@gmail.com>
Tim Flannagan (timflannagan)
changed the title
Correct the Apache license URL so the boilerplate verifier recognizes the header in the Linux DNS relay. Previously, the header used the HTTPS form while the verifier requires the repository's exact HTTP boilerplate and reported the header as missing. Now the relay uses the standard boilerplate and passes license verification. Signed-off-by: timflannagan <timflannagan@gmail.com>
2 tasks done
| ) | ||
|
|
||
| // Serve serves UDP and TCP DNS in the sandbox's local gateway namespace. | ||
| func (r *Relay) Serve(ctx context.Context, ns netns.Handle) (*Server, error) { |
Collaborator
There was a problem hiding this comment.
Should we have an explicit panic or return err function in //go:build !linux
Contributor
Author
There was a problem hiding this comment.
Not sure I follow - this is existing code. If we're talking about error handling, I think the current code is correct vs. panicing
Bowei Du (bowei)
approved these changes
Oct 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make testfailed on macOS for two host-specific reasons. The DNS relayreferenced Linux-only network namespace APIs from an otherwise portable file,
and the object storage tests inherited exported
AWS_PROFILEandAWS_DEFAULT_PROFILEvalues from the developer's shell.Move only the namespace-serving method behind a Linux build tag so portable
DNS tests still run on macOS. Clear both AWS profile selectors in the object
storage test so local AWS configuration cannot affect it.