Fence restored guest ownership and stream bounded process output - #68
Closed
Jesse McGinnis (brayzn) wants to merge 2 commits into
Closed
Jesse McGinnis (brayzn) wants to merge 2 commits into
Jesse McGinnis (brayzn) wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a guest snapshot can also restore the previous controller's live RPCs and processes. Add opt-in controller fencing so a newly admitted owner cancels and finishes the prior owner's RPCs, drains tracked process groups, and rejects stale calls. Authentication remains the responsibility of the router; ownership generations must come from outside the guest.
Also accept caller-generated process UUIDs for cancellation before a start response arrives; reject duplicate starts without replay; bound output messages to 64 KiB and drain the reaper's final output. Root filesystem operations with Go's
os.Root, add rooted removal and process draining RPCs, and hold working-directory descriptors through Linux startup in ownership mode. Existing guest deployments retain their default ownership behavior. Go and Python protocol bindings are regenerated.Validation:
go test -race ./...passes. A Linux container integration using the compiled guest and grpc-js also passes owner handoff, stale writes, pre-start cancellation, process-group cancellation, streamed 5 MiB files, output limits, symlink escape rejection, and cold restart with workspace preservation.