fix: restore iOS PWA viewport after keyboard dismiss - #387
Open
Windrunner20 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the large blank strip left below the composer after dismissing the software keyboard in an installed iOS PWA.
Cause
WebKit can dispatch
visualViewport.resizebeforevisualViewport.heightreflects the restored full-screen height. The viewport hook read that stale value synchronously and could leave--app-viewport-heightset to the keyboard-reduced height, so the whole chat layout remained shorter after the keyboard closed.This event ordering is documented in WebKit bug 254861:
https://bugs.webkit.org/show_bug.cgi?id=254861#c4
Fix
requestAnimationFramefocusin,focusout, andpageshowValidation
NODE_ENV=test node --test components/*.test.mjs hooks/*.test.mjs lib/*.test.mjs— 241 passed./node_modules/.bin/tsc --noEmitnpm run lintgit diff --checkA final physical-device check should reproduce by opening the composer keyboard in standalone mode and dismissing it using both the keyboard button and a tap outside the editor.