Skip to content

fix: enable title generation after compaction #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sleepinginsummer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enable title generation after compaction #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions components/AppShell.auto-name.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import assert from "node:assert/strict";
import fs from "node:fs";
import test from "node:test";

const source = fs.readFileSync(new URL("./AppShell.tsx", import.meta.url), "utf8");

test("压缩后的会话仍可根据持久化消息数生成标题", () => {
assert.match(
source,
/\(sessionStats\?\.userMessages \?\? 0\) > 0 \|\| selectedSession\.messageCount > 0/,
);
});
3 changes: 2 additions & 1 deletion components/AppShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,9 +1023,10 @@ export function AppShell() {
{!isMobile && <span>{translate("history.label")}</span>}
</button>
{(() => {
// 上下文压缩后当前消息可能不再包含 user 消息，需同时参考会话文件的消息总数。
const hasMessages = Boolean(
selectedSession
&& (sessionStats?.userMessages ?? selectedSession.messageCount) > 0,
&& ((sessionStats?.userMessages ?? 0) > 0 || selectedSession.messageCount > 0),
);
const disabled = !selectedSession || !hasMessages || autoNameStatus.kind === "naming";
const isSuccess = autoNameStatus.kind === "success";
Expand Down