Skip to content

feat: browser notification when agent session ends #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xCss wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

feat: browser notification when agent session ends #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion components/AppShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,21 @@ export function AppShell() {
const handleAgentEnd = useCallback(() => {
setRefreshKey((k) => k + 1);
setExplorerRefreshKey((k) => k + 1);
}, []);

if (document.visibilityState === "visible") return;
if (!("Notification" in window)) return;

const fire = () => {
const title = selectedSession?.name ?? translate("i18n.sessionComplete");
new Notification(title, { body: translate("i18n.taskFinished") });
};

if (Notification.permission === "granted") {
fire();
} else if (Notification.permission === "default") {
void Notification.requestPermission().then((p) => { if (p === "granted") fire(); });
}
}, [selectedSession, translate]);

const handleAutoName = useCallback(async () => {
const sessionId = selectedSession?.id;
Expand Down
2 changes: 2 additions & 0 deletions lib/i18n/messages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,5 +433,7 @@ export const enLocale: LocalePlugin = {
"i18n.thinkingUnavailable": "Thinking content unavailable",
"i18n.before": "Before",
"i18n.after": "After",
"i18n.sessionComplete": "Session complete",
"i18n.taskFinished": "Task finished.",
},
};
2 changes: 2 additions & 0 deletions lib/i18n/messages/zh-CN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,5 +433,7 @@ export const zhCNLocale: LocalePlugin = {
"i18n.thinkingUnavailable": "思考内容不可用",
"i18n.before": "之前",
"i18n.after": "之后",
"i18n.sessionComplete": "任务完成",
"i18n.taskFinished": "任务已完成。",
},
};