Repository navigation
fix(rust): harden APIs and transport features before 0.2.0 publication - #3385
mattsp1290 wants to merge 28 commits into
Conversation
…ust-sdk-1-0-parity/nxzo-1
…ust-sdk-1-0-parity/corrected-target
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
| run: cargo build --verbose | ||
|
|
||
| - name: Install compiler and quality tools | ||
| run: rustup toolchain install ${{ matrix.toolchain }} --profile minimal --component clippy,rustfmt |
| workspaces: sdks/community/rust | ||
| key: ${{ matrix.toolchain }} | ||
| - name: Build all public crates and test targets | ||
| run: cargo +${{ matrix.toolchain }} build --workspace --all-targets --locked |
| - name: Check formatting | ||
| run: cargo fmt -- --check | ||
|
|
||
| run: cargo +${{ matrix.toolchain }} fmt --all -- --check |
| run: cargo +${{ matrix.toolchain }} fmt --all -- --check | ||
| - name: Check clippy | ||
| run: cargo clippy -- -D warnings | ||
| run: cargo +${{ matrix.toolchain }} clippy --workspace --all-targets --locked -- -D warnings |
| run: cargo clippy -- -D warnings | ||
| run: cargo +${{ matrix.toolchain }} clippy --workspace --all-targets --locked -- -D warnings | ||
| - name: Complete fixture, producer, HTTP and lifecycle suites | ||
| run: cargo +${{ matrix.toolchain }} test --workspace --all-targets --locked |
| - name: Complete fixture, producer, HTTP and lifecycle suites | ||
| run: cargo +${{ matrix.toolchain }} test --workspace --all-targets --locked | ||
| - name: Doctests | ||
| run: cargo +${{ matrix.toolchain }} test --workspace --doc --locked |
| - name: Documentation warnings | ||
| env: | ||
| RUSTDOCFLAGS: -D warnings | ||
| run: cargo +${{ matrix.toolchain }} doc --workspace --no-deps --locked |
Python Preview PackagesVersion
Install with uvAdd the TestPyPI index to your [[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
explicit = trueThen install the packages you need: # Core SDK
uv add 'ag-ui-protocol==0.0.0.dev1794501883' --index testpypi
# Integrations (each already depends on the matching ag-ui-protocol preview)
uv add 'ag-ui-langgraph==0.0.0.dev1794501883' --index testpypi
uv add 'ag-ui-crewai==0.0.0.dev1794501883' --index testpypi
# NOTE: ag-ui-agent-spec depends on pyagentspec (git-only, not on PyPI).
# You will need to install pyagentspec separately from its git repo.
uv add 'ag-ui-agent-spec==0.0.0.dev1794501883' --index testpypi
uv add 'ag_ui_adk==0.0.0.dev1794501883' --index testpypi
uv add 'ag_ui_strands==0.0.0.dev1794501883' --index testpypiInstall with pippip install \
--index-url https://test.pypi.org/simple/ \
--extra-index-url https://pypi.org/simple/ \
ag-ui-protocol==0.0.0.dev1794501883
Commit: fd27cb5 |
@ag-ui/a2a-middleware
@ag-ui/a2ui-middleware
@ag-ui/event-throttle-middleware
@ag-ui/mcp-apps-middleware
@ag-ui/mcp-middleware
@ag-ui/a2a
@ag-ui/adk-js
@ag-ui/adk
@ag-ui/ag2
@ag-ui/agno
@ag-ui/antigravity
@ag-ui/aws-strands
@ag-ui/claude-agent-sdk
@ag-ui/claude-managed-agents
@ag-ui/crewai
@ag-ui/langchain
@ag-ui/langgraph
@ag-ui/llamaindex
@ag-ui/mastra
@ag-ui/openai-agents
@ag-ui/pydantic-ai
@ag-ui/vercel-ai-sdk
@ag-ui/watsonx
@ag-ui/a2ui-toolkit
create-ag-ui-app
@ag-ui/client
@ag-ui/core
@ag-ui/encoder
@ag-ui/proto
commit: |
surlymochan
left a comment
There was a problem hiding this comment.
Verified the incremental follow-up commit (99c0677, on top of #3214's head ac80258) locally — I did not re-run the full 205-test matrix, so this is a scoped check, not a whole-PR approval:
cargo test -p ag-ui-core(Rust 1.99.1 here; the PR body used 1.88): 84 passed, 0 failed, including the 5 doctests with the compile-fail checks for the non-exhaustive enums.cargo test -p ag-ui-client --lib: 18 passed, 0 failed.- Spot-checked the claimed API changes in the diff:
#[non_exhaustive]is present on the event enums incrates/ag-ui-core/src/event.rs; zero remaining references to the removedAgUiClientError::ExchangeIdentity/EventValidationError::EmptyDeltavariants anywhere undercrates/; the typedPatchErrorenum exists incrates/ag-ui-core/src/patch.rs(DocumentTooDeep/OperationTooDeep).
No issues found in the slice I verified — non-binding review, no approval implied. Note this is a draft stacked on #3214, so I did not touch mergeability.
Purpose and dependency
This is the pre-publication follow-up to #3214, requested before merging that PR. It is stacked on its approved head
ac80258e24292867b8feb14626ab115ee49dc2e8; do not merge this draft before #3214. Because the parent branch lives in a fork, the upstream base ismainand the Files changed view currently includes the parent. The incremental follow-up is commit99c0677(focused comparison). Once #3214 lands, reconcile this branch ontomainbefore final review.Prepared by Forg, an AI agent assisting Matt.
Changes requested before publishing 0.2.0
Addresses Joshua’s approval and publication checklist:
DiagnosticCategory,RunTerminalStatus, andEventValidationErrornon-exhaustive.http,native-tls, andrustls-tlsfeatures. Defaults retain native TLS and previous HTTP/2, charset and system-proxy support. Disabling defaults removes HTTP/reqwest while keeping the agent pipeline and bounded SSE decoder.PatchErrorfromapply_patch_to_copy, preserving bounded, disposable-copy behavior and regression coverage.AgUiClientError::ExchangeIdentityandEventValidationError::EmptyDeltavariants.Also clarifies that captured HTTP error bodies are absent from Display/Debug, not absent from structured errors.
Earlier review threads
The individual disposition audit covers all 51 inline threads on #3214 with code/test evidence. It separates fixes already present in the parent from this follow-up and documented limitations. GitHub threads and security alerts have not been marked resolved by that audit. No additional important runtime defect was found during the audit.
Local verification
none, HTTP-only, rustls-only, all features): all-target tests, doctests and strict Clippy passed for each on Rust 1.88.Hosted CI passed on
99c06777db72bef426d4fabb3fd16d8040cbdd3b: all 13 substantive workflows, including the eight-job Rust qualification/feature matrix, interoperability and fresh Git consumer, and all 39 E2E jobs. This draft does not publish crates, merge either PR, or change the documented cancellation/memory limitations.