Repository navigation
COMSE-124: Add info modal close control - #298
Merged
Merged
Conversation
noahjalex
marked this pull request as ready for review
August 14, 2026 23:37
noahjalex
force-pushed
the
nalexander/COMSE-124/info-modal-close
branch
from
August 17, 2026 19:51
e022cff to
70f934d
Compare
2 tasks
noahjalex
force-pushed
the
nalexander/COMSE-124/info-modal-close
branch
from
August 17, 2026 19:58
70f934d to
7c73499
Compare
noahjalex
changed the base branch from
nalexander/fix-zero-minimum
to
nalexander/fix-sandbox-sample
August 17, 2026 19:58
finci-square
approved these changes
Aug 21, 2026
jasonjin-ap
approved these changes
Aug 21, 2026
noahjalex
force-pushed
the
nalexander/COMSE-124/info-modal-close
branch
from
August 24, 2026 15:42
5539e4d to
a53f45b
Compare
psymoon
approved these changes
Aug 24, 2026
noahjalex
force-pushed
the
nalexander/COMSE-124/info-modal-close
branch
from
August 31, 2026 18:40
a53f45b to
12ff534
Compare
Replace the floating circular overlay with a conventional native header above the WebView. - Root is a vertical LinearLayout: a fixed-light header, then the WebView with layout_weight=1, so web content can never render beneath the control instead of relying on z-order and a margin. - The 48x48dp ImageButton keeps its 24dp glyph, 12dp padding and "Close information modal" description, but drops the permanent white fill and 4dp elevation in favour of a transparent idle background and the standard borderless selectable ripple. - Colours come from the existing afterpay_white/afterpay_black resources, and the now unused afterpay_close_button_background ripple drawable is removed. - AfterpayInfoActivity gets a scoped AfterpayInfoDialog theme so the light header sits on coherent black-on-white dialog chrome under a dark system theme. Other SDK activities keep AfterpayDialog. Dismissal behaviour is unchanged. Tests cover the accessibility contract, the header/WebView hierarchy and the dismissal result. The layout's end gravity makes lint raise RtlEnabled for the library manifest. Left as is deliberately: declaring android:supportsRtl in an SDK manifest would merge into and change RTL behaviour for host apps. Co-authored-by: Claude Code <noreply@anthropic.com>
Move the close control's content description into the AfterpayString code-side localization (EN + FR_CA) that the SDK uses for user-facing strings, keeping an English-only resource default for the layout. Assert the icon drawable and ripple background in the activity test.
noahjalex
force-pushed
the
nalexander/COMSE-124/info-modal-close
branch
from
August 31, 2026 18:43
12ff534 to
3cdcf9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Android's Afterpay information modal had no visible dismissal control; users had to discover system Back.
Solution
Add a fixed-light native header above the WebView with a borderless 48×48dp close action, black X, platform ripple, and
Close information modalaccessibility label (localized in code viaAfterpayString, EN + FR_CA). The control is independent of hosted HTML and does not overlay modal content.Validation
Companion hosted-content fix: https://github.com/AfterpayTouch/paylater-static/pull/919