Skip to content

ASSIGNMENT-2 SQL#2

Open
afesobi wants to merge 5 commits intoassignment-twofrom
main
Open

ASSIGNMENT-2 SQL#2
afesobi wants to merge 5 commits intoassignment-twofrom
main

Conversation

@afesobi
Copy link
Owner

@afesobi afesobi commented Feb 4, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@kelichiu kelichiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total Point: 63/70

Section 1: 40/46

  • Date table is missing its relationships with other tables with dates (Order, and Employee_Shift as well)
  • Order Table is actually the orders of new books from suppliers to refill the stock, not customer orders. Having relationship with Sales is incorrect.
  • Relationships between tables are not indicated (one-to-one, one-to-many, or many-to-many)

Section 2: 7/8

  • WINDOW FUNCTION Q1: When use ROW_NUMBER, the data of customer_id and market_date is not unique. We need to use GROUP BY to get the unique combination of customer_id and market_date in data.

Section 3: 8/8

Section 4: 8/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants