Skip to content

I am trying this with Colab, hopefully it works fine.#1

Open
afesobi wants to merge 2 commits intomainfrom
Assignment-1
Open

I am trying this with Colab, hopefully it works fine.#1
afesobi wants to merge 2 commits intomainfrom
Assignment-1

Conversation

@afesobi
Copy link
Owner

@afesobi afesobi commented Feb 17, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@afesobi afesobi changed the title I am trying this with Colab, hopefully ikt works fine. I am trying this with Colab, hopefully it works fine. Feb 17, 2025
" word_b = word_b.lower()\n",
"\n",
" # Use Counter to compare character occurrences\n",
" return Counter(word_a) == Counter(word_b)\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counter() is a very powerful tool, but is probably a overuse for the task. We can simply compare two strings without turning them into dictionaries:
word_a == word_b

Copy link

@kelichiu kelichiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Fesobi, I noticed that you were writing your codes on a separate file with a different format. I can see that you are doing the right thing with both tasks. However, for the next assignment, please consider modifying the provided assignment file and keep the format the same, it will make the marking more of a sooth and fair process.

Pass

Code Execution

All code cells execute without errors.

Code Quality

  • Code is well-organized, concise.
  • Codes includes necessary comments for clarity.
  • Great use of variable names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants