Repository navigation
tests: record sweep timeout SIGTERM delivery directly - #3461
adilalperenciftci wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
The fork workflows are waiting for approval before the jobs can start. Could a maintainer approve the run when convenient? |
|
The failed
I attempted to rerun job A maintainer rerun of the failed ARM64 job is required. If either 504 result repeats, I will compare the rerun timing and resolver output against the successful main job. |
Record termination in the native foreground and background helpers instead of depending on when the shell emits trap output. Keep the timeout status, process-group cleanup, and Windows no-signal assertions unchanged. Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
426a5de to
dd2e6e0
Compare
|
Thanks @adilalperenciftci! This landed in #3474, which batched nine of your PRs and merged on 2026-10-30 ( |
Summary
I traced the macOS-only
integration_sweep_timeoutfailure to the test depending on when Bash emits its SIGTERM trap output. The bound had already returned 124 and removed both helper processes, but the platform-specific trap diagnostic was not a stable delivery witness.This change records SIGTERM directly in the native foreground and background helpers. The test still verifies the 124 timeout status, process-group cleanup, sweep-shell survival, and the Windows no-signal invariant.
Validation
make test- 634 passed, 0 failedmake check-testsmake check-changelogbash tests/integration/sweep_timeout/test_sweep_timeout.shwith GCCCC=clang bash tests/integration/sweep_timeout/test_sweep_timeout.sh