Repository navigation
tests: run shared-map hosts with sandbox ABI - #3460
Closed
adilalperenciftci wants to merge 1 commit into
Closed
adilalperenciftci wants to merge 1 commit into
adilalperenciftci wants to merge 1 commit into
Conversation
Compile the in-process bridges with sandbox checker support and export each detected runtime library path before execution. This lets versioned Debian and Ubuntu runtimes reach the grant-map assertions instead of failing during setup. Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
nicolas-maman
approved these changes
Oct 30, 2026
Collaborator
|
Thanks @adilalperenciftci! This landed in #3474, which batched nine of your PRs and merged on 2026-10-30 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I traced the shared-map host sweep's empty Python and Perl output to two setup failures in the test harness:
AETHER_HAS_SANDBOX, leaving the sandbox checker ABI unavailable.dlopenloaders on systems that only provide versioned libraries.The sweep now compiles those bridges with the sandbox ABI enabled and exports the detected runtime library paths before execution. No host bridge or runtime implementation changes are included.
Verification
test_shared_map_all.shreported 0 passed / 5 failed; direct compilation exposed the missing sandbox checker type and state.test_shared_map_all.shreports 5 passed / 0 failed with the available Python and Perl runtimes.make check-changelogmake check-testsmake test(634 passed, 0 failed)Signed-off-by: Adil Alperen Çiftci adilalperenciftci@users.noreply.github.com