Repository navigation
runtime: honor zero sandbox verbosity - #3451
Closed
adilalperenciftci wants to merge 1 commit into
Closed
adilalperenciftci wants to merge 1 commit into
adilalperenciftci wants to merge 1 commit into
Conversation
Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
nicolas-maman
approved these changes
Oct 30, 2026
Collaborator
|
Thanks @adilalperenciftci! This landed in #3474, which batched nine of your PRs and merged on 2026-10-30 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I traced unexpected sandbox stderr output to the legacy verbosity override.
spawn_sandboxedsuppliesAETHER_SANDBOX_VERBOSE=0for quiet children, but the preload constructor treated any defined value as enabled and replaced the selected log mode with stderr.This change applies the legacy override only when the value is exactly
1. The default zero value now preservesAETHER_SANDBOX_LOG, while the documented enabled value remains unchanged.Verification
AETHER_SANDBOX_VERBOSE=0emitted the active-sandbox diagnostic on stderr.0stays quiet and1enables stderr diagnostics.sh tests/integration/sandbox_verbose_flag/test_sandbox_verbose_flag.shsh tests/integration/sandbox_child_signal_safe/test_sandbox_child_signal_safe.shmake check-changelogmake check-testsmake test(634 passed)Signed-off-by: Adil Alperen Çiftci adilalperenciftci@users.noreply.github.com