Repository navigation
fix(compiler): fail closed at effect analysis limits - #3447
adilalperenciftci wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
31a5211 to
1cd2956
Compare
|
Rebased onto current main at Ubuntu VM verification:
Updated head: |
|
Thanks @adilalperenciftci! This landed in #3474, which batched nine of your PRs and merged on 2026-10-30 ( |
Summary
I traced a fail-open path in effect-tag validation to the checker's bounded call-graph walk. Once recursion exceeded 128 levels, or the visited set reached 512 functions, the unexamined path was treated as capability-free and the annotated function could compile.
This change:
Verification
sh tests/integration/effect_tag_limits/test_effect_tag_limits.shsh tests/integration/effect_tags/test_effect_tags.shsh tests/integration/aetherc_emit_effects/test_aetherc_emit_effects.shmake check-changelogmake check-testsmake test(634 passed)Signed-off-by: Adil Alperen Çiftci adilalperenciftci@users.noreply.github.com