[CLIENT-4834] Fix memory error when shared memory is enabled and server version is read before sending user agent string#1067
Draft
juliannguyen4 wants to merge 14 commits into
Conversation
…nitialized read when testing shm locally
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1067 +/- ##
=======================================
Coverage 84.44% 84.44%
=======================================
Files 99 99
Lines 14062 14062
=======================================
Hits 11874 11874
Misses 2188 2188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
Resolved by deleting the existing shared memory segment locally. But when rerunning without deleting the shared memory segment, a crash occurs.
|
…ll_socket -> FD_SET() where fd is -1.
… one in the docstring for as_config doesn't match the implementation
…tops the test from crashing, remove this default shm key so we don't need to manually update it if the c client updates the default one (e.g in this PR)
…000000 stops the test from crashing, remove this default shm key so we don't need to manually update it if the c client updates the default one (e.g in this PR)" This reverts commit aec7da9.
…ent instance if they use the same host seeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO