Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several lazy features are pulled in with a dynamic
import(...).then(...)that has no rejection handler. A dynamic import can reject at the network level with:on a transient failure (offline, connection reset, or a request blocked by an extension). With no handler, that rejection becomes an unhandled promise rejection and surfaces in monitoring. Note that a surrounding synchronous
try/catchdoes not catch it, since the failure is async.Fix
Guard the three unhandled dynamic imports in
scripts.jsso a failed module fetch degrades gracefully instead of throwing an unhandled rejection:Each uses the two-argument
.then(onFulfilled, onRejected)form, so only the import rejection is handled — a genuine error thrown inside the fulfilled callback still propagates and stays visible.Test URLs
To reproduce: load a page that uses one of these features (e.g. a page with a fragment reference) and cause the module request to fail at the network level (offline, or blocked by an extension). Before the fix this throws an unhandled rejection; after the fix the feature degrades quietly and the page stays healthy.
🤖 Generated with Claude Code