Repository navigation
fix(web): decode inline images before revealing them - #328
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large external JPEGs can make a frame commit wait for image decoding and delay keyboard input after a sort change. The live performance gate measured 800 ms and 704 ms. New inline images now keep their reserved box hidden until decoding completes. Images already visible in the bootstrap handover stay visible; errors still reveal their alt text/image, and the lightbox retains the original source.
Add six decode/error/navigation regressions and bounded interaction diagnostics. The Event Timing actions, settling, uncapped maximum and strict 100 ms limit remain unchanged. No provider, media proxy, dependency, workflow or deployment-trigger changes.
Validation: required local checks (607 tests, formatting, native/Wasm/static-host Clippy, licenses), normal build; 31 focused decode/layout/exact early-paint cases; isolated smoothness70pass/twoexisting skips, zero retries. Original CPU4 profiling reproduced192–312ms; initial-hide prototype40–56ms. The actual Rust build measured40–64ms against live public data under CPU4; one diagnostic run had a proxy teardown error after measurement, retained separately; the corrected drain/wait harness passed at48ms with all API reads200. The earlier failed main check is retained as failed, and will not be rerun to green.