Repository navigation
fix(web): preserve presence updates and video keyboard controls - #326
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presence changes during an in-flight heartbeat could lose their refresh. Keep one pending refresh and send the latest visibility/session state after the older request finishes. A held-response regression reproduces the loss on the deployed build and passes with this repair.
The phone video sound test also exposed Space keydown/up arriving at the focused badge without a native activation click. Handle Space release explicitly, suppress its default duplicate, and disarm on blur. Repeated keydowns leave sound unchanged; Enter retains the native button action. The same control keeps focus, playback, scroll and media source.
Live sort tests wait for the interactive app. Back geometry uses the wider week range while retaining the 100+ cards and all geometry/count assertions. Profile boot failures retain bounded, sanitized browser and pending-asset diagnostics.
Validation:
CI40109657076 remains failed after the original video case recovered on retry; its artifact and input timeline are retained. This is a changed-source repair, not a rerun of that commit. The previous full production run also remains rejected, with six failures retained. Upstream cast search has since recovered; shard freshness still needs acceptance. One profile boot failure remains unexplained despite ten clean focused attempts, so the new diagnostics are not presented as a proven fix. Final main/live verification is still required. DM testing is waived; the owner reserves the release tag.