Skip to content

fix(web): preserve presence updates and video keyboard controls - #326

Merged
ael-dev3 merged 2 commits into
mainfrom
fix/presence-refresh
Oct 24, 2026
Merged

ael-dev3 merged 2 commits into
mainfrom
fix/presence-refresh

Conversation

@ael-dev3

@ael-dev3 ael-dev3 commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Presence changes during an in-flight heartbeat could lose their refresh. Keep one pending refresh and send the latest visibility/session state after the older request finishes. A held-response regression reproduces the loss on the deployed build and passes with this repair.

The phone video sound test also exposed Space keydown/up arriving at the focused badge without a native activation click. Handle Space release explicitly, suppress its default duplicate, and disarm on blur. Repeated keydowns leave sound unchanged; Enter retains the native button action. The same control keeps focus, playback, scroll and media source.

Live sort tests wait for the interactive app. Back geometry uses the wider week range while retaining the 100+ cards and all geometry/count assertions. Profile boot failures retain bounded, sanitized browser and pending-asset diagnostics.

Validation:

  • Required formatting, native/WebAssembly/static-host Clippy, 607 unit tests and license audit passed.
  • Strengthened sound/focus tests: 24 passed across desktop/phone, zero retries, covering held repeats, Space release and Enter.
  • Isolated smoothness: 70 passed, two existing profile-performance fixmes, zero retries.
  • Presence regression and signed-in controls: 4 passed; complete affected presence/profile fixture suites: 31 passed, one existing declared skip.
  • Live week Back and profile-width checks: 4 passed; New readiness passed separately.
  • All 911 tests retain their IDs; no requirement, budget, trigger or assertion is relaxed.

CI40109657076 remains failed after the original video case recovered on retry; its artifact and input timeline are retained. This is a changed-source repair, not a rerun of that commit. The previous full production run also remains rejected, with six failures retained. Upstream cast search has since recovered; shard freshness still needs acceptance. One profile boot failure remains unexplained despite ten clean focused attempts, so the new diagnostics are not presented as a proven fix. Final main/live verification is still required. DM testing is waived; the owner reserves the release tag.

@ael-dev3 ael-dev3 changed the title fix(web): retain presence refreshes during in-flight beats fix(web): preserve presence updates and video keyboard controls Oct 24, 2026
@ael-dev3
ael-dev3 merged commit 3fe7ea9 into main Oct 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant