Repository navigation
fix(notifications): retain initial reads and verify release behavior - #324
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Opening Notifications while its split module loads now shares the bell's initial read. A failed initial read stays visible until the reader chooses Try again, and a fresh answer is reused instead of being read twice. Regression tests delay the real split module to reproduce both paths.
Profile cards cannot queue a hover reopening while their closing animation runs. A trusted-pointer regression reproduces the previous Escape dismissal failure; the original CI event sequence was not captured, so it is not claimed as a proven diagnosis of that run.
The release browser checks now follow the current feed contract: seen rows are restored through Show seen posts, pagination proves the failed request was retried, wallet checks use the actual RPC results, and upload checks ignore unrelated analytics requests. Debounce and reply-layout checks control their setup without changing the product's timing limits.
Miniflare's nested Undici is pinned to 7.30.1 for its content-encoding, EventSource, and integrity-check security fixes. The override applies to the current Miniflare version; Wrangler, Miniflare, workerd, and the SDK's separate Undici copy retain their versions.
Validation
An earlier strict local phone measurement failed the 50 ms overlapping-task limit (64 ms median) while the host had a 0.59 CPU share. That failure is retained and its cause is not established; the later diagnostic run does not replace final deployed verification. No threshold changed or failure was waived. Clean independent CI and final untraced production verification remain required.
The initial PR CI run passed the 605 native and four module tests, then stopped at the npm security audit before any browser tests ran. Its failure is retained; the dependency patch requires a new clean run.
The security-patched CI run passed native/module checks, the audit and quiet smoothness, but failed the strict flake gate when one profile card remained open after Escape. Functional fixtures reported 758 passed, one flaky and 21 skipped; quiet smoothness reported 70 passed and two existing fixmes. Static tests did not run. The recovered retry remains a failure, and the follow-up source fix needs a clean new exact-head run.
Production verification and the complete source-pinned browser suite follow the normal main deployment. The owner creates the release tag.