Raid v2 - #1008

Open

maximeroucher wants to merge 49 commits into

mainfrom

maximeroucher commented May 17, 2026 •

edited

Loading

Member

Description

Summary

Restructuring some of raid registering to match challenger idea :

Edition system
Participant derived from coreuser instead of separate entity
Volunteer registration and handling

Classification

Type of Change

🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
🔧 Infra CI/CD (changes to configs of workflows)
💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
😶‍🌫️ No impact for the end-users

Impact & Scope

Testing

1. Tested this locally
2. Added/modified tests that pass the CI (or tested in a downstream fork)
3. Tested in a deployed pre-prod
0. Untestable (exceptionally), will be tested in prod directly

Documentation

Updated the docs accordingly :
" Docstrings
# Inline comments
No documentation needed

warix8 reviewed

View reviewed changes

app/core/core_endpoints/cruds_core.py Outdated

app/modules/raid/utils/validation_checker.py Outdated

tests/config.test.yaml Outdated

tests/conftest.py Outdated

tests/test_migrations.py Outdated

app/modules/raid/cruds_raid.py

PabloBellissant commented Jun 1, 2026

The CI checks are currently failing:
Lint and format / lintandformat (pull_request)

Could you please check the linting and formatting issues please ?

maximeroucher force-pushed the Raid-V2 branch from 37be12c to 10e6be2 Compare

June 5, 2026 22:18

maximeroucher commented Jun 5, 2026

Member Author

Everything fixed, comment taken into accounts, if you want to check the changes.
Nice review, btw, raised only legitimate and fair points, GG for the level up !
Keep it up, the project is on really good hands ❤️

maximeroucher requested a review from warix8

June 5, 2026 22:26

codecov Bot commented Jun 5, 2026 •

edited

Loading

Codecov Report

❌ Patch coverage is 80.43758% with 152 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.96%. Comparing base (2afec59) to head (2847f46).

Files with missing lines	Patch %	Lines
app/modules/raid/endpoints_raid.py	62.16%	84 Missing ⚠️
app/modules/raid/cruds_raid.py	65.28%	42 Missing ⚠️
app/modules/raid/utils/validation_checker.py	91.58%	9 Missing ⚠️
app/modules/raid/schemas_raid.py	95.85%	7 Missing ⚠️
app/modules/raid/utils/utils_raid.py	81.25%	6 Missing ⚠️
app/modules/raid/dependencies_raid.py	93.10%	2 Missing ⚠️
app/modules/raid/factory_raid.py	95.65%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   84.61%   83.96%   -0.66%     
==========================================
  Files         214      217       +3     
  Lines       15523    16014     +491     
==========================================
+ Hits        13135    13446     +311     
- Misses       2388     2568     +180

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

maximeroucher force-pushed the Raid-V2 branch from 4379982 to ff11328 Compare

June 23, 2026 13:43

maximeroucher and others added 13 commits

July 22, 2026 18:55


          feat(raid): add RaidRegistrationStatus enum for participant state mac…

af76ccf

…hine

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(config): add phone and birthday fields to UserDemoFactoryConfig

d4865c5

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): add migration for edition scoping and registration state …

8e91e0a

…machine

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): add migration for volunteer registration table

a632054

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): rewrite models with edition scoping, state machine, and v…

db97d30

…olunteers

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): rewrite schemas for edition-scoped participants and volun…

61bc941

…teers

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): rewrite CRUDs with edition scoping and volunteer operations

0bede2c

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): add edition-aware FastAPI dependencies for participant/vo…

6022f4c

…lunteer lookup

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): add validation checker for participant document and field…

290fc23

… completeness

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): add factory for seeding raid test data with editions

38ed3c6

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): update payment validation and security file helpers for e…

66257e7

…dition scoping

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          feat(raid): rewrite endpoints with edition scoping, state machine, an…

ec6040c

…d volunteer flow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          fix(raid): update security file template to use user relationship fields

6e0323e

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

maximeroucher force-pushed the Raid-V2 branch from 90d2ef5 to 03425fc Compare

July 22, 2026 18:46

maximeroucher and others added 9 commits

July 22, 2026 21:31


          test(raid): rewrite tests for edition-scoped registration and volunte…

812c81c

…er flow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


          fix: test and linting

5ad6ea1


          refacto(cruds): splitting models from schema

77da0f3


          refacto(documents): more readable document progress calculation

34444ed


          fix(format): resolving ruff conflict rule on comma

6b63632


          fix(migration): reordering after rebase

c85de9d


          fix(raid): cancelled records no longer block re-registration on the o…

0c18cef

…ther track

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>


          fix(raid): cancelled participants and volunteers no longer block edit…

a4e7a1f

…ion deletion

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>


          fix: importing at the top of the file

6f97774


          ci(test): raise Postgres lock-table sizing for 8 parallel workers

cda594d

The 8 xdist workers each drop and re-create ~126 tables plus indexes
and FKs in a single transaction, which brushes past the default
max_locks_per_transaction=64 * max_connections=100 lock-table size and
sporadically fails with "out of shared memory / You might need to
increase max_locks_per_transaction". Append the tuned values to
postgresql.conf, restart the service container, and wait for readiness
before running tests.

GHA services can't set command args directly, so we name the container
and docker exec into it after startup.

armanddidierjean reviewed

View reviewed changes

.github/workflows/test.yml Outdated

app/modules/raid/cruds_raid.py Outdated

app/modules/raid/cruds_raid.py

app/modules/raid/cruds_raid.py Outdated

app/modules/raid/cruds_raid.py Outdated

app/modules/raid/cruds_raid.py Outdated

app/modules/raid/cruds_raid.py

app/modules/raid/dependencies_raid.py

migrations/versions/61-raid_editions_and_state.py Outdated

migrations/versions/61-raid_editions_and_state.py Outdated

armanddidierjean commented Aug 5, 2026

Member

Main coverage drop by 0.8%, it could be great to add a few additionnal tests, especially given the complexity of the module

maximeroucher and others added 12 commits

August 5, 2026 13:53


          fix(raid): type update_participant/update_volunteer params, add alias…

5b9de5f

… comments, manual schema instantiation, use exclude_unset


          fix(raid): make get_participant_or_404/get_volunteer_or_404 proper Fa…

99520cc

…stAPI dependencies


          fix(migration): use real UUID for DEFAULT_EDITION_ID

64bd21c


          fix(migration): add pre_test_upgrade and test_upgrade for raid_editio…

9a432ec

…ns_and_state

- Seed core_school, core_user, raid_participant, raid_team, raid_document,
  raid_security_file, raid_invite with data matching pre-migration schema
- Add assertions in test_upgrade to verify migration produces expected state
- Fix column names (birthday, uploaded_at, type enum values, difficulty, meeting_place)
- Remove make_user_external from core_user (column doesn't exist in this revision)
- Add is_minor to raid_participant (required NOT NULL column)


          fix(migration): update core_user model and migration test data for ma…

238f3ca

…ke_user_external

- Add make_user_external field to CoreUser model
- Update 17-external_user_email_migration.py pre_test_upgrade to use make_user_external
- Update 61-raid_editions_and_state.py pre_test_upgrade to use make_user_external

Co-authored-by: Claude <noreply@anthropic.com>


          fix(migration): correct pre_test_upgrade column names for core_user

a249263

- Use make_user_external instead of external in 17-external_user_email_migration.py
- Use make_user_external instead of external in 61-raid_editions_and_state.py

Co-authored-by: Claude <noreply@anthropic.com>


          fix(migration): restore 'external' column in 17 pre_test_upgrade

b2336ab


          fix(model): remove duplicate make_user_external from CoreUser

e7ea7b8


          fix(migration): remove make_user_external from 61 pre_test_upgrade in…

60f46d9

…serts


          test(raid): add coverage tests for utils_raid (21 tests)

6573fb9


          ci: remove Postgres parallel tuning (separate PR)

445de8d


          fix: formatting

e6db58d

maximeroucher force-pushed the Raid-V2 branch from 8be00e8 to e6db58d Compare

August 6, 2026 15:28

armanddidierjean added 4 commits

August 7, 2026 10:50


          fix: format

0977aa0


          fix: don't create table in raid tests

60e6db2


          fix: remove uv.lock

4c51c00


          fix: lint and format

c71b097

armanddidierjean reviewed

View reviewed changes

uv.lock Outdated

armanddidierjean approved these changes

View reviewed changes

armanddidierjean left a comment

Member

LGTM!


          fix: pass participant in test_calculate_raid_payment_no_participant

a315bdf

armanddidierjean mentioned this pull request

max_locks_per_transaction config for tests #1034

Open

armanddidierjean and others added 6 commits

August 7, 2026 11:39


          fix: remove test_calculate_raid_payment_no_participant

9dea8b4


          fix: participant can not be falsy in calculate_raid_payment

2847f46


          fix: remove unused pypdf and types-fpdf2 dependencies

e2310b1


          fix: add unique constraint on raid_team.second_id to fix join race

e6a9964


          fix: add orphan file rollback in upload_document endpoint

6dc4c60


          fix: remove /raid/drive endpoints and RaidDriveFolders coredata

5241e0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet