SCIX-813 feat(nav): add count badge to graphics menu item

[thostetler]

Summary

• Display figure count badge on the Graphics menu item in abstract side nav, matching the pattern used by Citations, References, Credits, and Mentions
• Add staleTime: 5min to useGetGraphicsCount to reduce redundant refetches when navigating between abstract subpages
• Fix MSW mock handler routing bug (':id' → '/:id')

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.5%. Comparing base (7286f0e) to head (3184f7f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #817     +/-   ##
========================================
+ Coverage    62.4%   62.5%   +0.1%     
========================================
  Files         317     317             
  Lines       36564   36565      +1     
  Branches     1674    1671      -3     
========================================
+ Hits        22802   22818     +16     
+ Misses      13724   13709     -15     
  Partials       38      38             

Files with missing lines	Coverage Δ
src/api/graphics/graphics.ts	76.7% <100.0%> (+8.3%)	⬆️
src/components/AbstractSideNav/AbstractSideNav.tsx	95.9% <100.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Risk summary: Medium — user-facing navigation change is low risk, but the updated graphics count query can currently fire with an undefined bibcode, and the graphics page still links out to http:// URLs.

This PR adds a figure-count badge to the Abstract side navigation’s Graphics item (matching existing count-badge patterns), reduces redundant graphics-count refetching via React Query staleTime, and fixes an MSW handler route pattern for the graphics endpoint.

Changes:

• Show a count badge for Graphics in the Abstract side nav and disable when count is 0.
• Add staleTime: 5min to useGetGraphicsCount to reduce refetching while navigating.
• Fix MSW graphics handler routing (':id' → '/:id') and add/extend a test to assert the badge appears.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/components/AbstractSideNav/AbstractSideNav.tsx	Adds CountBadge as rightElement for the Graphics nav item using graphicsCount.
src/api/graphics/graphics.ts	Adds a 5-minute staleTime for the graphics-count query.
src/mocks/handlers/graphics.ts	Fixes MSW route matching for the graphics endpoint by adding the missing /.
src/components/__tests__/AbstractSideNav.test.tsx	Adds a test that waits for and asserts the Graphics count badge.
src/pages/abs/[id]/graphics.tsx	Normalizes thumbnail URLs to https:// when rendering NextImage.

[Copilot]

The thumbnail URL is normalized to HTTPS, but the click-through href still uses http:// (e.g., doi.org). This can trigger mixed-content/insecure navigation warnings from an HTTPS page and is inconsistent with the thumbnail fix. Consider normalizing figure.images[0].highres to HTTPS as well (or using a shared URL-normalization helper for both).

[Copilot]

useGetGraphicsCount will execute a query even when bibcode is undefined (the type is optional), resulting in requests like /graphics/undefined and caching under a key with an undefined bibcode. Add an enabled: !!bibcode default (while still allowing callers to override via options) so the query is skipped until a valid bibcode is available.

[Copilot]

This test assertion is fairly brittle: it relies on getAllByText('Graphics'), picks the first match, then walks up the DOM with closest('a, button'). This can become flaky if both the side + top nav render in the DOM or if the markup changes. Prefer querying the specific nav item by accessible role/name (e.g., a link/button named "Graphics") and then asserting the badge within that element (using Testing Library within), ideally with findBy... instead of wrapping synchronous queries in waitFor.