Skip to content

Upgrade Stimulus dependency to @hotwired/stimulus #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duyanton wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade Stimulus dependency to @hotwired/stimulus #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.m.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.m.js.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/index.umd.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.umd.js.map
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"amdName": "StimulusFlatpickr",
"author": "@adrienpoly",
"license": "MIT",
"external": "stimulus, flatpickr",
"external": "@hotwired/stimulus, flatpickr",
"scripts": {
"start:playground": "webpack-dev-server --mode development --open --config playground/webpack.config.js --hot",
"build": "rollup -c && yarn test",
Expand All @@ -27,7 +27,7 @@
},
"peerDependencies": {
"flatpickr": ">=4.6.2",
"stimulus": ">=1.1.1"
"@hotwired/stimulus": ">=3.0.1"
},
"devDependencies": {
"@babel/core": "^7.6.0",
Expand Down Expand Up @@ -73,7 +73,7 @@
"sinon": "^6.1.4",
"sinon-chai": "^3.2.0",
"size-plugin": "^1.0.1",
"stimulus": "^1.1.1",
"@hotwired/stimulus": "^3.0.1",
"style-loader": "^0.23.0",
"webpack": "^4.39.3",
"webpack-cli": "^3.2.3",
Expand All @@ -87,4 +87,4 @@
"resolutions": {
"minimist": "^1.2.5"
}
}
}
2 changes: 1 addition & 1 deletion playground/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Application } from 'stimulus'
import { Application } from '@hotwired/stimulus'
import FlatpickrController from './controllers/flatpickr_controller'

const application = Application.start()
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ manually register a new Stimulus controller in your main JS entry point.

```js
// ./packs/application.js
import { Application } from 'stimulus'
import { definitionsFromContext } from 'stimulus/webpack-helpers'
import { Application } from '@hotwired/stimulus'
import { definitionsFromContext } from '@hotwired/stimulus-webpack-helpers'

const application = Application.start()
const context = require.context('../controllers', true, /\.js$/)
Expand Down
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const pkg = require('./package.json')

export default {
input: 'src/index.js',
external: ['stimulus', 'flatpickr'],
external: ['@hotwired/stimulus', 'flatpickr'],
output: [
{
file: 'dist/index.js',
Expand Down
2 changes: 1 addition & 1 deletion spec/flatpickr_controller_events_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// import Flatpickr from './controllers/flatpickr_hook_controller'
import { Application } from 'stimulus'
import { Application } from '@hotwired/stimulus'
import StimulusFlatpickr from './controllers/flatpickr_hook_controller'
import 'flatpickr/dist/flatpickr.css'
import { registerController, nextFrame, fixtureQuerySelector, addFlatpickrOption } from './helpers'
Expand Down
2 changes: 1 addition & 1 deletion spec/flatpickr_controller_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Application } from 'stimulus'
import { Application } from '@hotwired/stimulus'
import chai, { expect } from 'chai'
import chaiDom from 'chai-dom'

Expand Down
2 changes: 1 addition & 1 deletion spec/flatpickr_controller_targets_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import StimulusFlatpickr from './controllers/flatpickr_controller'
import { Application } from 'stimulus'
import { Application } from '@hotwired/stimulus'
import 'flatpickr/dist/flatpickr.css'
import { nextFrame } from './helpers'
import chai, { expect } from 'chai'
Expand Down
2 changes: 1 addition & 1 deletion spec/flatpickr_custom_element_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Application } from 'stimulus'
import { Application } from '@hotwired/stimulus'
import chai, { expect } from 'chai'
import chaiDom from 'chai-dom'

Expand Down
2 changes: 1 addition & 1 deletion spec/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Application } from 'stimulus'
import { Application } from '@hotwired/stimulus'

const nextFrame = async () => {
return new Promise((resolve) => requestAnimationFrame(resolve))
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Controller } from 'stimulus'
import { Controller } from '@hotwired/stimulus'
import flatpickr from 'flatpickr'
import { kebabCase, capitalize } from './utils'
import { options, dateFormats } from './config_options'
Expand Down
37 changes: 5 additions & 32 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,11 @@
lodash "^4.17.13"
to-fast-properties "^2.0.0"

"@hotwired/stimulus@^3.0.1":
version "3.0.1"
resolved "https://registry.yarnpkg.com/@hotwired/stimulus/-/stimulus-3.0.1.tgz#141f15645acaa3b133b7c247cad58ae252ffae85"
integrity sha512-oHsJhgY2cip+K2ED7vKUNd2P+BEswVhrCYcJ802DSsblJFv7mPFVk3cQKvm2vHgHeDVdnj7oOKrBbzp1u8D+KA==

"@samverschueren/stream-to-observable@^0.3.0":
version "0.3.0"
resolved "https://registry.yarnpkg.com/@samverschueren/stream-to-observable/-/stream-to-observable-0.3.0.tgz#ecdf48d532c58ea477acfcab80348424f8d0662f"
Expand Down Expand Up @@ -808,30 +813,6 @@
resolved "https://registry.yarnpkg.com/@sinonjs/text-encoding/-/text-encoding-0.7.1.tgz#8da5c6530915653f3a1f38fd5f101d8c3f8079c5"
integrity sha512-+iTbntw2IZPb/anVDbypzfQa+ay64MW0Zo8aJ8gZPWMMK6/OubMVb6lUPMagqjOPnmtauXnFCACVl3O7ogjeqQ==

"@stimulus/core@^1.1.1":
version "1.1.1"
resolved "https://registry.yarnpkg.com/@stimulus/core/-/core-1.1.1.tgz#42b0cfe5b73ca492f41de64b77a03980bae92c82"
integrity sha512-PVJv7IpuQx0MVPCBblXc6O2zbCmU8dlxXNH4bC9KK6LsvGaE+PCXXrXQfXUwAsse1/CmRu/iQG7Ov58himjiGg==
dependencies:
"@stimulus/mutation-observers" "^1.1.1"

"@stimulus/multimap@^1.1.1":
version "1.1.1"
resolved "https://registry.yarnpkg.com/@stimulus/multimap/-/multimap-1.1.1.tgz#b95e3fd607345ab36e5d5b55486ee1a12d56b331"
integrity sha512-26R1fI3a8uUj0WlMmta4qcfIQGlagegdP4PTz6lz852q/dXlG6r+uPS/bx+H8GtfyS+OOXVr3SkZ0Zg0iRqRfQ==

"@stimulus/mutation-observers@^1.1.1":
version "1.1.1"
resolved "https://registry.yarnpkg.com/@stimulus/mutation-observers/-/mutation-observers-1.1.1.tgz#0f6c6f081308427fed2a26360dda0c173b79cfc0"
integrity sha512-/zCnnw1KJlWO2mrx0yxYaRFZWMGnDMdOgSnI4hxDLxdWVuL2HMROU8FpHWVBLjKY3T9A+lGkcrmPGDHF3pfS9w==
dependencies:
"@stimulus/multimap" "^1.1.1"

"@stimulus/webpack-helpers@^1.1.1":
version "1.1.1"
resolved "https://registry.yarnpkg.com/@stimulus/webpack-helpers/-/webpack-helpers-1.1.1.tgz#eff60cd4e58b921d1a2764dc5215f5141510f2c2"
integrity sha512-XOkqSw53N9072FLHvpLM25PIwy+ndkSSbnTtjKuyzsv8K5yfkFB2rv68jU1pzqYa9FZLcvZWP4yazC0V38dx9A==

"@szmarczak/http-timer@^1.1.2":
version "1.1.2"
resolved "https://registry.yarnpkg.com/@szmarczak/http-timer/-/http-timer-1.1.2.tgz#b1665e2c461a2cd92f4c1bbf50d5454de0d4b421"
Expand Down Expand Up @@ -7471,14 +7452,6 @@ static-extend@^0.1.1:
resolved "https://registry.yarnpkg.com/statuses/-/statuses-1.5.0.tgz#161c7dac177659fd9811f43771fa99381478628c"
integrity sha1-Fhx9rBd2Wf2YEfQ3cfqZOBR4Yow=

stimulus@^1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/stimulus/-/stimulus-1.1.1.tgz#53c2fded6849e7b85eed3ed8dd76e33abd74bec5"
integrity sha512-R0mBqKp48YnRDZOxZ8hiOH4Ilph3Yj78CIFTBkCwyHs4iGCpe7xlEdQ7cjIxb+7qVCSxFKgxO+mAQbsNgt/5XQ==
dependencies:
"@stimulus/core" "^1.1.1"
"@stimulus/webpack-helpers" "^1.1.1"

stream-browserify@^2.0.1:
version "2.0.2"
resolved "https://registry.yarnpkg.com/stream-browserify/-/stream-browserify-2.0.2.tgz#87521d38a44aa7ee91ce1cd2a47df0cb49dd660b"
Expand Down