Repository navigation
feat: add focus events to GridListItem - #10822
Open
dagemawinegash wants to merge 1 commit into
Open
dagemawinegash wants to merge 1 commit into
dagemawinegash wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
onFocus,onBlur, andonFocusChangetoGridListItemfor mouse and keyboard interaction, using the existinguseFocushook. Includes regression tests and an interactive Storybook example.Part of #6460 (GridListItem only; table Row is outside this change).
✅ Pull Request Checklist:
API prop documentation derives from the inherited
FocusEventstype; no separate documentation files were changed.📝 Test Instructions:
yarn startand open React Aria Components → GridList → Item Focus Events.yarn test packages/react-aria-components/test/GridList.test.js --runInBand.Validation: all 110 GridList tests, repository lint, and all 74 SSR tests passed (SSR used a 120-second local timeout). The full unit run had 16 failing tests and the browser run had two failures. All reproduced with the original GridList source: unit failures involve Windows locale/path handling and an interactive codemod fixture; browser failures involve TokenField word deletion in Chromium and Firefox.
🧢 Your Project:
Independent open-source contribution.