Skip to content

fix: have card type attachments render at full width so file name and description are visible - #10818

Merged
yihuiliao merged 1 commit into
mainfrom
fix_attachment_width
Oct 22, 2026
Merged

yihuiliao merged 1 commit into
mainfrom
fix_attachment_width

Conversation

@LFDanLu

@LFDanLu LFDanLu commented Oct 20, 2026

Copy link
Copy Markdown
Member

Caught from testing

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at AGENTS.md.

📝 Test Instructions:

Look at the AttachmentList stories and make sure the "card" attachments render with visible titles/descriptions
image

Sanity check PromptField and AttachmentGrid also render card/thumbnail attachments just fine

🧢 Your Project:

RSP

@rspbot

rspbot commented Oct 20, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Oct 20, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (9)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/49a792e468061be6d40ab8d07db8ff902318287d/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/49a792e468061be6d40ab8d07db8ff902318287d/

@LFDanLu

LFDanLu commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1323, kinda weird that Chromatic's chrome snapshot renders the stories scrolled somehow? Might be their Chrome version cuz I'm unable to reproduce

@yihuiliao
yihuiliao added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 3b7c4d1 Oct 22, 2026
32 of 33 checks passed
@yihuiliao
yihuiliao deleted the fix_attachment_width branch October 22, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants