Repository navigation
fix: sheet enter offscreen travel - #10815
Merged
snowystinger merged 2 commits intoOct 22, 2026
Merged
Conversation
snowystinger
approved these changes
Oct 22, 2026
snowystinger
left a comment
Member
There was a problem hiding this comment.
tested with reduced motion as well, that's still working as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10808
Summary
Sheet is visibly delayed when entering with
position="end" / "start"on wide screens, asonEnterscrolls the container a full viewport. Sheets narrower or shorter than the viewport spend most of the animation off screen. Most noticeable on widescreens but reduces dead time in almost all cases (including mobile screens withposition="bottom").Fix
Jump to where the sheet's leading edge meets the viewport before smooth scrolling, so the animation is instant after clicking the trigger.
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the
Sheetdocs on a widescreen, change position to "end" and observe the delay for the backdrop to fade and sheet to enter. On this branch, run the docs locallyyarn start:s2-docsand do the same check, there is now no delay.current:
https://github.com/user-attachments/assets/04d10da4-f177-4668-a587-8a5cba853580
fix:
https://github.com/user-attachments/assets/0fb27146-d265-4f9b-bc2d-35501c617c4a
Added new tests in
Sheet.test.js🧢 Your Project:
ISM Fantasy Games (Fantasy Premier League)