feat: add selectAllLabel prop to TableView for customizing the aria-label of the select all checkbox - #10530
Open
zinap-ensemble wants to merge 1 commit into
Open
Conversation
… all checkbox's aria-label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10529
✅ Pull Request Checklist:
📝 Test Instructions:
TableView's select all checkbox (
selectionMode="multiple"selectionStyle="checkbox") has anaria-labelhardcoded to the localized "Select All" string, with no way to override it. This is a problem when a page renders multiple TableViews — every select all checkbox announces identically, so screen reader users can't tell them apart (fails WCAG 3.3.2, see #10529).This PR adds an optional
selectAllLabelprop toTableViewto override that label. It's opt-in only — the default "Select All"/"Select" behavior is unchanged for existing consumers, so this is non-breaking.To test:
yarn start, open the TableView stories, select "custom select all labeling".aria-labelshould read "Select all items" instead of "Select All".selectAllLabel) — still reads "Select All".🧢 Your Project: