fix(react-stately): set allowOverflow on TableLayout nodes for sticky columns - #10528
Open
sundeep8967 wants to merge 2 commits into
Open
fix(react-stately): set allowOverflow on TableLayout nodes for sticky columns#10528sundeep8967 wants to merge 2 commits into
sundeep8967 wants to merge 2 commits into
Conversation
… columns Fixes adobe#10518 by setting allowOverflow = true across TableLayout nodes (header, headerrow, column, row, cell), ensuring that columns marked as sticky via isStickyColumn() are not clipped during virtualized scroll. Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TableLayoutexposesisStickyColumn()as a protected extension point to configure sticky columns. While overriding it setsLayoutInfo.isStickyand maintains persisted indices,TableLayoutpreviously never setLayoutInfo.allowOverflow = trueon its layout nodes.As a result, in
VirtualizerItem(layoutInfoToStyle), sticky column cells were clipped and offset by parent scroll coordinates rather than remaining visually pinned in the viewport during virtualized horizontal scrolling.Solution
Updated
TableLayout.tsacrossbuildTableHeader,buildHeaderRow,buildColumn,buildRow, andbuildCellto setallowOverflow = true, bringingTableLayoutin line with sibling layouts (ListLayout,GridLayout,WaterfallLayout).Fixes #10518