fix: add suppressHydrationWarning to GlobalDOMAttributes and update f… - #10527
Open
miszuto wants to merge 1 commit into
Open
fix: add suppressHydrationWarning to GlobalDOMAttributes and update f…#10527miszuto wants to merge 1 commit into
miszuto wants to merge 1 commit into
Conversation
…ilterDOMProps tests
snowystinger
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, were you running into an issue where SSR wasn't working? Can you provide a reproduction? Ideally, you'd open an Issue first with that information so that a PR doesn't just appear, we have some context for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filterDOMPropsdid not forwardsuppressHydrationWarning, even though it is a valid React prop for handling unavoidable server/client hydration differences.This change adds the prop to
GlobalDOMAttributesand to the global attributes handled byfilterDOMProps. Components using this utility can now forward it to the DOM only when{global: true}is specified. Unit tests cover both the inclusion and stripping behavior.✅ Pull Request Checklist:
📝 Test Instructions:
Run the
filterDOMPropsunit tests and verify that:suppressHydrationWarningis retained with{global: true}.{global: true}.AI assistance
I used an AI assistant to help draft the implementation and tests. I reviewed, understand, and take responsibility for every change in this PR.