fix(breaking-change): ACNA-3718 - remove @openwhisk/wskdebug from the default action generator#77
Merged
purplecabbage merged 1 commit intomainfrom Apr 16, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 361 362 +1
Branches 60 61 +1
=========================================
+ Hits 361 362 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 7, 2025
Member
Author
|
10 separate PRs will be filed for the repos below, dependent on this PR being merged and released as a major version v3. These libs need to update their @adobe/generator-app-common-lib dep to the new major version v3, and subsequently update to major versions themselves: These two require the libs above to updated to new major versions: Lastly:
|
amulyakashyap09
approved these changes
Apr 15, 2025
moritzraho
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using the app-dev plugin for local debugging now.
See also: adobe/aio-cli-plugin-app#854
This is a
BREAKING CHANGEso it requires a major version update.Unfortunately, it has 28 dependents - so those dependents will need to update their version of common lib IF they use the
addActionfunctionality. Ideally we update everything.Start with https://github.com/adobe/generator-aio-app/blob/420490da23ac758cdcf5c5556781ef963850263a/package.json#L51C1-L61C43
How Has This Been Tested?
Types of changes
Checklist: