feat: instrument desktop shell with cooperative AEM RUM#14
Open
davidnuescheler wants to merge 2 commits into
Open
feat: instrument desktop shell with cooperative AEM RUM#14davidnuescheler wants to merge 2 commits into
davidnuescheler wants to merge 2 commits into
Conversation
Add a local /.rum proxy to rum.hlx.page, load helix-rum-js in the renderer for stock top/click collection, and fire virtual pageview tops on shell navigation with https://desktop.aem.live referers. Co-authored-by: Cursor <cursoragent@cursor.com>
Chromium net.fetch blocks cross-origin Referer values, causing 502s on beacon POSTs. Keep site identity in the JSON body only. Also force RUM sampling in dev since the file:// shell has no ?rum=on query string. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/.rumproxy in the main process that forwards torum.hlx.pageand normalizes beacon referers tohttps://desktop.aem.livehelix-rum-js(with enhancer) in the app shell so sampled sessions get OOTBtopandclickcollectiontoppageviews on shell navigation (home, site browse, file open, review) viasampleRUM, not directsendPingcallsTest plan
npm test && npm run lint?rum=on(or wait for a sampled session) and confirm/.rumscript + beacon requests in DevToolstoppings carryhttps://desktop.aem.live/...referersclickpings inherit the last virtual page referer via the proxyMade with Cursor