BUGFIX align with api spec#57
Merged
Martin187187 merged 12 commits intoadmin-shell-io:IDTA-01004-3-0-2_Workingfrom Mar 31, 2026
Merged
BUGFIX align with api spec#57Martin187187 merged 12 commits intoadmin-shell-io:IDTA-01004-3-0-2_Workingfrom
Martin187187 merged 12 commits intoadmin-shell-io:IDTA-01004-3-0-2_Workingfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This was referenced Mar 6, 2026
whamm86
reviewed
Mar 10, 2026
| USEOBJECTS "Properties" | ||
| FORMULA: | ||
| USEFORMULAS "allowSubjectGroup1" | ||
| USEFORMULA "allowSubjectGroup1" |
There was a problem hiding this comment.
I have tested this in BNF playground. And it won't work anymore.
BNF Playground does not accept the last line in the example:
FORMULA:
USEFORMULA "allowSubjectGroup1"
But this will work:
FORMULA:
$and(
GLOBAL(UTCNOW) $gt "15:00",
$or(
CLAIM("email") $eq "user1@company1.com",
CLAIM("email") $eq "user2@company2.com"
)
)
I think you have to change the example or there is a problem with the definition of USEFORMULA
Collaborator
Author
There was a problem hiding this comment.
I've looked into this problem. Turns out some important parentheses were missing in the BNF. I also updated the examples so they work with the fixed BNF again.
whamm86
suggested changes
Mar 10, 2026
whamm86
left a comment
whamm86
left a comment
There was a problem hiding this comment.
There seems to be a problem with USEFORMULA, I have commented on that
Collaborator
Author
Thank you for your review! |
whamm86
approved these changes
Mar 10, 2026
Collaborator
Author
|
can be merged as api bugfix was approved and merged. |
Martin187187
merged commit bd51b49
into
admin-shell-io:IDTA-01004-3-0-2_Working
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #59 #60 #61 #62
This Pull Request solves the following:
fixed bugs: