Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/yummy-taxis-laugh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
---

CI-only change: consume the Ladon PR reviewer from `adcontextprotocol/actions`
instead of the vendored `.secretariat/ai-review/` tree. No library, CLI, or
published-file impact, so no release is required.
1 change: 0 additions & 1 deletion .github/codeql/codeql-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ paths-ignore:
- examples/**
- scripts/manual-testing/**
- test/**
- .secretariat/ai-review/**
32 changes: 17 additions & 15 deletions .github/workflows/ai-review.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
name: AI PR Review (AAO-SECRETARIAT)
name: AI PR Review (Ladon)

# AAO-SECRETARIAT reviews every non-draft, non-dependabot PR. The heavy lifting lives in
# the forked action tree under .secretariat/ai-review/ (setup → reviewer → arbiter),
# adapted from Scope3's PR-review action set. This workflow only handles the
# pull_request_target security posture (trusted base-SHA checkout only; the PR
# head is never fetched, checked out, or executed — setup reads head content
# via the GitHub API), the review-workflow-modification gate, and invoking
# the composite. Reviews post as the AAO Secretariat App so they count toward the
# "1 review required" branch-protection check.
# Ladon reviews every non-draft, non-dependabot PR. The heavy lifting lives in
# the shared action tree at adcontextprotocol/actions (ladon/), consumed here by
# floating major tag. This workflow handles the pull_request_target security
# posture (trusted base-SHA checkout only; the PR head is never fetched, checked
# out, or executed - setup reads head content via the GitHub API), the
# review-workflow-modification gate, and invoking the composite. Reviews post as
# the AAO Secretariat App so they count toward the "1 review required"
# branch-protection check.
#
# pull_request_target (not pull_request) is required on a public repo so that PRs
# from forks can access the App token and Anthropic key.

on:
pull_request_target:
types: [opened, labeled, ready_for_review, synchronize]
paths-ignore:
- '.github/workflows/ai-review.yml'
- '.secretariat/ai-review/**'
- 'AAO-SECRETARIAT.md'
- 'LADON.md'

jobs:
code_review:
Expand Down Expand Up @@ -58,7 +60,7 @@ jobs:
MODIFIED=""
while IFS= read -r f; do
case "$f" in
.secretariat/ai-review/*|.github/workflows/ai-review.yml|AAO-SECRETARIAT.md)
.github/workflows/ai-review.yml|LADON.md)
MODIFIED="${MODIFIED}${f}"$'\n' ;;
esac
done <<< "$CHANGED"
Expand All @@ -85,12 +87,12 @@ jobs:
repo: context.repo.repo,
pull_number: context.issue.number,
event: 'COMMENT',
body: `AAO-SECRETARIAT is **not auto-reviewing** this PR because it modifies the review system itself (${files}). A human reviewer should review and merge this PR; AAO-SECRETARIAT resumes on subsequent PRs once these changes land on \`main\`.`
body: `Ladon is **not auto-reviewing** this PR because it modifies the review system itself (${files}). A human reviewer should review and merge this PR; Ladon resumes on subsequent PRs once these changes land on \`main\`.`
});

- name: Run AAO-SECRETARIAT
- name: Run Ladon
if: steps.workflow-mod.outputs.modified != 'true'
uses: ./.secretariat/ai-review/review
uses: adcontextprotocol/actions/ladon/review@ladon/review/v1
with:
anthropic-api-key: ${{ secrets.ANTHROPIC_API_KEY }}
app-id: ${{ secrets.SECRETARIAT_APP_ID }}
Expand Down
26 changes: 0 additions & 26 deletions .github/workflows/secretariat-dist-check.yml

This file was deleted.

9 changes: 1 addition & 8 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,4 @@ test/fixtures/webhook-signing-vectors/
# `static/examples/products/canonical/` + `server/src/creative-agent/`.
# Byte-identical to upstream so projection tests don't drift on local
# formatting changes.
test/lib/v2-projection-fixtures/

# AAO-SECRETARIAT v2 code-review system, forked verbatim from scope3data/actions
# (aao-secretariat-v2/ tree). Files here are fetched byte-for-byte from upstream so
# the fork stays diffable against its source; prettier would reformat them
# and mask real upstream drift. See .secretariat/ai-review/README.md for the pinned
# SHA and fork rationale.
.secretariat/ai-review/
test/lib/v2-projection-fixtures/
19 changes: 0 additions & 19 deletions .secretariat/ai-review/README.md

This file was deleted.

5 changes: 0 additions & 5 deletions .secretariat/ai-review/arbiter/.gitignore

This file was deleted.

85 changes: 0 additions & 85 deletions .secretariat/ai-review/arbiter/action.yml

This file was deleted.

148 changes: 0 additions & 148 deletions .secretariat/ai-review/arbiter/dist/33.index.js

This file was deleted.

27 changes: 0 additions & 27 deletions .secretariat/ai-review/arbiter/dist/index.js

This file was deleted.

3 changes: 0 additions & 3 deletions .secretariat/ai-review/arbiter/dist/package.json

This file was deleted.

Loading
Loading