Skip to content

fix(ci): review pull_request_target events#2382

Merged
bokelley merged 1 commit into
mainfrom
fix/argus-pull-request-target
Jul 21, 2026
Merged

fix(ci): review pull_request_target events#2382
bokelley merged 1 commit into
mainfrom
fix/argus-pull-request-target

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

  • recognize pull_request_target as a pull-request event in AAO-SECRETARIAT setup
  • preserve support for direct pull_request events and reject unrelated events
  • rebuild the committed setup action bundle

Root cause

The repository invokes AAO-SECRETARIAT from a pull_request_target workflow, but setup only accepted an exact pull_request event name. Every review therefore exited successfully with skip-reason=not-a-pull-request before the reviewer or arbiter ran.

Security posture

The workflow continues to check out only the trusted base SHA. The PR head remains API-read data and is never fetched or executed.

Validation

  • setup action Vitest: 8 files, 68 tests passed
  • setup action typecheck passed in isolated expert validation
  • setup action production bundle rebuilt
  • local security reviewer: no findings
  • local code reviewer: no findings

This PR modifies the reviewer itself, so the repository intentionally requires human/local review and will not self-review it.

@bokelley
bokelley merged commit ff62a85 into main Jul 21, 2026
28 of 29 checks passed
@bokelley
bokelley deleted the fix/argus-pull-request-target branch July 21, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant