refactor(bitimage): use shared.ToLittleEndian for size conversion#115
refactor(bitimage): use shared.ToLittleEndian for size conversion#115
Conversation
Replace manual bitwise operations for little-endian conversion with the `shared.ToLittleEndian` helper function in `download_graphics_commands.go`, `graphics_commands.go`, and `nv_graphics_commands.go`. This improves code readability and maintainability by standardizing on the shared utility. Affected functions: - `DefineDownloadGraphics` - `DefineDownloadGraphicsColumn` - `StoreRasterGraphicsInBuffer` - `StoreColumnGraphicsInBuffer` - `DefineNVRasterGraphics` - `DefineNVColumnGraphics` Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
👋 Thanks for opening this PR, @adcondev! Here's what will happen next:
Please make sure:
|
⚡ Benchmark Results📈 Performance Comparison📊 Click to expand detailed resultsCurrent Branch ResultsBase Branch Results💡 Note: Use 🎯 Summary
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Replaced manual little-endian conversion logic with
shared.ToLittleEndianinpkg/commands/bitimagepackage to improve code health and consistency. Confirmed functionality with existing tests.PR created automatically by Jules for task 8170664250265593066 started by @adcondev