Repository navigation
feat: add utilities for handling multiple assertions - #309
Merged
Merged
Conversation
Since pytest doesn't have an equivalent of stretchr require/assert or Googletest's EXPECT/ASSERT.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds a reusable multiassert context manager for aggregating schema metadata validation failures.
Changes:
- Adds
multiassert()usingExceptionGroup. - Applies it to field metadata validation.
- Adds tests for grouped assertion failures.
| File | Description |
|---|---|
tests/test_utils.py |
Tests aggregated assertion failures. |
adbc_drivers_validation/utils.py |
Implements and integrates multi-assertion handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lidavidm
marked this pull request as ready for review
September 24, 2026 07:55
Mandukhai-Alimaa
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pytest doesn't have an equivalent of stretchr require/assert or Googletest's EXPECT/ASSERT.