Repository navigation
feat: test parameter stream binding - #306
Conversation
c8b9cfc to
1cc5c8a
Compare
Add tests for binding SQL parameters from Arrow streams. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
There was a problem hiding this comment.
Is this really necessary? I can see the argument for testing the tests, but I think the approach there needs some consideration, vs just throwing mocks at things
There was a problem hiding this comment.
(And, while I don't know what was used here, I have found that LLMs really really want to spam out tests like this when I use them with this codebase.)
There was a problem hiding this comment.
What do you think about some form of snapshot testing? Perhaps using https://15r10nk.github.io/inline-snapshot/latest/?
So we have some test setups against perhaps sqlite, and create snapshots of what SQL queries that gets run and which assertion are made, which can be inspected and updated? Trade-offs as always, but perhaps a good fit here?
Perhaps create a "decide on testing strategy/ambitions" issue.
There was a problem hiding this comment.
Yeah, again, I'd like to understand why it's necessary to test this in the first place.
3 participants
Add tests for binding SQL parameters from Arrow streams.
Closes #133