Skip to content

fix: embed timezone data in Go shared libraries #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mandukhai-Alimaa merged 1 commit into from
Oct 15, 2026
Merged

fix: embed timezone data in Go shared libraries #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion adbc_drivers_dev/make_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,8 @@ def build_plan(self, config: MakeEnv) -> MakePlan:
# Embed Go version
f"-X {_GO_VERSION_FLAG}={config.version}",
]
tags = ["driverlib"]
# Include IANA timezone data when the host has no timezone database.
tags = ["driverlib", "timetzdata"]
if config.debug:
tags.append("assert")
tags.extend(self.lang.build_tags)
Expand Down
6 changes: 3 additions & 3 deletions tests/test_make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def test_go_linux_amd64(go_driver_root: tuple[Path, Path]) -> None:
"module",
"build",
"-buildmode=c-shared",
"-tags=driverlib,custom_feature,release_feature",
"-tags=driverlib,timetzdata,custom_feature,release_feature",
"-ldflags=-w -X github.com/adbc-drivers/driverbase-go/driverbase.infoDriverVersion=0.1.0",
"-o",
"build/libadbc_driver_godummy.so",
Expand All @@ -247,7 +247,7 @@ def test_go_linux_amd64(go_driver_root: tuple[Path, Path]) -> None:

config.debug = True
plan = make_config.build_plan(config)
assert "-tags=driverlib,assert,custom_feature" in plan.commands[0]
assert "-tags=driverlib,timetzdata,assert,custom_feature" in plan.commands[0]


def test_go_linux_amd64_ci(go_driver_root: tuple[Path, Path]) -> None:
Expand Down Expand Up @@ -277,7 +277,7 @@ def test_go_linux_amd64_ci(go_driver_root: tuple[Path, Path]) -> None:
"module",
"build",
"-buildmode=c-shared",
"-tags=driverlib",
"-tags=driverlib,timetzdata",
"-ldflags=-w -X github.com/adbc-drivers/driverbase-go/driverbase.infoDriverVersion=0.1.0 -linkmode external -extldflags=-Wl,--version-script=/only-export-adbc.ld",
"-o",
"build/libadbc_driver_godummy.so",
Expand Down
Loading