Repository navigation
chore(deps): bump async-trait so fmt + clippy passes on stable 1.99 - #98
Merged
Merged
Conversation
…st_use Stable clippy (1.99) rejects the #[must_use] that async-trait 0.1.89 emits on its generated methods, failing fmt + clippy on main and every branch since 2026-10-01.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmt + clippyhas been red onmainand on every branch since 2026-10-01, including the docs-only #96 and #97.Cause
CI installs stable Rust unpinned. Clippy 1.99 added
double_must_usecases that fire on the#[must_use]async-trait 0.1.89 puts on its generated methods, so all four#[async_trait]traits infleetd(DocSource,Forge,Planner,Runner) fail under-D warnings. No source in this repo changed.Fix
cargo update -p async-trait: 0.1.89 -> 0.1.92 in the rootCargo.lock. It brings insyn 3.0.5as a build dependency of the macro. No source changes.Verification
CI on this branch:
fmt + clippypasses, both the root workspace andcockpit/ui/src-tauriclippy steps. Not reproduced locally, since the local toolchain is 1.93 and does not have the lint.Not in this PR
The toolchain is still unpinned, so the next stable release can do this again. Pinning it is a separate decision, and it is related to #95.