Fix FIND_LINKS_REGEX to match any whitespace after <a#130
Open
danishashko wants to merge 1 commit intoadbar:masterfrom
Open
Fix FIND_LINKS_REGEX to match any whitespace after <a#130danishashko wants to merge 1 commit intoadbar:masterfrom
danishashko wants to merge 1 commit intoadbar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex
<a [^<>]+?>uses a literal space which misses valid anchor tags that use tabs or multiple spaces between<aand the first attribute.Changing to
<a\s+[^<>]+?>covers any whitespace character, which is more robust and consistent with how HTML is written in the wild.Quick check: