fix: fallback to GET from HEAD in redirect check on 500#128
Open
donbowman wants to merge 6 commits intoadbar:masterfrom
Open
fix: fallback to GET from HEAD in redirect check on 500#128donbowman wants to merge 6 commits intoadbar:masterfrom
donbowman wants to merge 6 commits intoadbar:masterfrom
Conversation
Some sites do not implement HEAD, giving a 500, but, are otherwise valid sites. Fallback to GET in this case. Resolves adbar#126
Owner
|
Thanks @donbowman, I just added a few changes. IMO the tests are failing because the CI pipeline hasn't been updated. Merging main into the branch should fix it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
===========================================
- Coverage 100.00% 94.35% -5.65%
===========================================
Files 11 11
Lines 825 833 +8
===========================================
- Hits 825 786 -39
- Misses 0 47 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sites do not implement HEAD, giving a 500, but, are otherwise valid sites. Fallback to GET in this case.
Resolves #126